Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1142263002: small cleanup of GrAtlas (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tidy #

Patch Set 3 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -97 lines) Patch
M src/gpu/GrAtlas.h View 4 chunks +1 line, -15 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 3 chunks +1 line, -59 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-19 21:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142263002/20001
5 years, 7 months ago (2015-05-19 21:24:01 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-19 21:24:03 UTC) #5
robertphillips
okay with me but I would like Jim to chime in too
5 years, 7 months ago (2015-05-19 21:30:03 UTC) #7
jvanverth1
lgtm
5 years, 7 months ago (2015-05-19 21:39:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d706f11b6e3f4398ab93b23458a7599ee324be2c
5 years, 7 months ago (2015-05-19 21:41:50 UTC) #9
bungeman-skia
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1142273002/ by bungeman@google.com. ...
5 years, 7 months ago (2015-05-19 21:44:35 UTC) #10
bungeman-skia
On 2015/05/19 21:44:35, bungeman1 wrote: > A revert of this CL (patchset #2 id:20001) has ...
5 years, 7 months ago (2015-05-19 21:47:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142263002/40001
5 years, 7 months ago (2015-05-19 21:53:22 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:05:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8debd89f6360dbf4b19c17e32bb0328bd7a08576

Powered by Google App Engine
This is Rietveld 408576698