Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/gpu/GrAtlas.cpp

Issue 1142263002: small cleanup of GrAtlas (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: tidy Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrAtlas.h ('k') | src/gpu/GrDrawTarget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrAtlas.cpp
diff --git a/src/gpu/GrAtlas.cpp b/src/gpu/GrAtlas.cpp
index 7ebdf6eb12587952d0d0233a7c28bca2dcdb2e73..0322f70dc07bbb0a2b56cf142575d147deb16512 100644
--- a/src/gpu/GrAtlas.cpp
+++ b/src/gpu/GrAtlas.cpp
@@ -21,8 +21,7 @@ static int g_UploadCount = 0;
#endif
GrPlot::GrPlot()
- : fDrawToken(NULL, 0)
- , fID(-1)
+ : fID(-1)
, fTexture(NULL)
, fRects(NULL)
, fAtlas(NULL)
@@ -106,36 +105,6 @@ bool GrPlot::addSubImage(int width, int height, const void* image, SkIPoint16* l
return true;
}
-void GrPlot::uploadToTexture() {
- static const float kNearlyFullTolerance = 0.85f;
-
- // should only do this if batching is enabled
- SkASSERT(fBatchUploads);
-
- if (fDirty) {
- TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("skia.gpu"), "GrPlot::uploadToTexture");
- SkASSERT(fTexture);
- // We pass the flag that does not force a flush. We assume our caller is
- // smart and hasn't referenced the part of the texture we're about to update
- // since the last flush.
- size_t rowBytes = fBytesPerPixel*fRects->width();
- const unsigned char* dataPtr = fPlotData;
- dataPtr += rowBytes*fDirtyRect.fTop;
- dataPtr += fBytesPerPixel*fDirtyRect.fLeft;
- fTexture->writePixels(fOffset.fX + fDirtyRect.fLeft, fOffset.fY + fDirtyRect.fTop,
- fDirtyRect.width(), fDirtyRect.height(), fTexture->config(), dataPtr,
- rowBytes, GrContext::kDontFlush_PixelOpsFlag);
- fDirtyRect.setEmpty();
- fDirty = false;
- // If the Plot is nearly full, anything else we add will probably be small and one
- // at a time, so free up the memory and after this upload any new images directly.
- if (fRects->percentFull() > kNearlyFullTolerance) {
- SkDELETE_ARRAY(fPlotData);
- fPlotData = NULL;
- }
- }
-}
-
void GrPlot::resetRects() {
SkASSERT(fRects);
fRects->reset();
@@ -258,30 +227,3 @@ void GrAtlas::RemovePlot(ClientPlotUsage* usage, const GrPlot* plot) {
usage->fPlots.remove(index);
}
}
-
-// get a plot that's not being used by the current draw
-GrPlot* GrAtlas::getUnusedPlot() {
- GrPlotList::Iter plotIter;
- plotIter.init(fPlotList, GrPlotList::Iter::kTail_IterStart);
- GrPlot* plot;
- while ((plot = plotIter.get())) {
- if (plot->drawToken().isIssued()) {
- return plot;
- }
- plotIter.prev();
- }
-
- return NULL;
-}
-
-void GrAtlas::uploadPlotsToTexture() {
- if (fBatchUploads) {
- GrPlotList::Iter plotIter;
- plotIter.init(fPlotList, GrPlotList::Iter::kHead_IterStart);
- GrPlot* plot;
- while ((plot = plotIter.get())) {
- plot->uploadToTexture();
- plotIter.next();
- }
- }
-}
« no previous file with comments | « src/gpu/GrAtlas.h ('k') | src/gpu/GrDrawTarget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698