Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1142213002: Revert of Move content:: scheme registrations from chrome/ to content/. (Closed)

Created:
5 years, 7 months ago by hiroshige
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move content:: scheme registrations from chrome/ to content/. (patchset #1 id:1 of https://codereview.chromium.org/1137103003/) Reason for revert: Breaks some layout tests BUG=489672 Original issue's description: > Move content:: scheme registrations from chrome/ to content/. > > Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we > should do their various renderer-side scheme registrations in content > (RenderThreadImpl::RegisterSchemes) rather than in chrome > (ChromeContentRendererClient::RenderThreadStarted). > > R=jochen@chromium.org > > Committed: https://crrev.com/dcd7aad11d33ffd6dffe440ce32a0228c0843a67 > Cr-Commit-Position: refs/heads/master@{#330506} TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b2ecf6a9a13aebad7b529ef5a39aa291f6542560 Cr-Commit-Position: refs/heads/master@{#330513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hiroshige
Created Revert of Move content:: scheme registrations from chrome/ to content/.
5 years, 7 months ago (2015-05-19 13:22:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142213002/1
5 years, 7 months ago (2015-05-19 13:22:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 13:23:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2ecf6a9a13aebad7b529ef5a39aa291f6542560 Cr-Commit-Position: refs/heads/master@{#330513}
5 years, 7 months ago (2015-05-19 13:24:17 UTC) #4
Mike West
On 2015/05/19 at 13:24:17, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/b2ecf6a9a13aebad7b529ef5a39aa291f6542560 > Cr-Commit-Position: ...
5 years, 7 months ago (2015-05-19 14:03:25 UTC) #5
Mike West
On 2015/05/19 at 14:03:25, Mike West (holiday in DE) wrote: > On 2015/05/19 at 13:24:17, ...
5 years, 7 months ago (2015-05-19 14:05:55 UTC) #6
Mike West
5 years, 7 months ago (2015-05-19 19:07:52 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1134303009/ by mkwst@chromium.org.

The reason for reverting is: Fixing the layout tests:

Patch 1: https://codereview.chromium.org/1143593006
Patch 2: [This patch]
Patch 3: https://codereview.chromium.org/1139053004/.

Powered by Google App Engine
This is Rietveld 408576698