Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1143593006: Skip tests whose expectations change based on scheme registration. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
Reviewers:
kenrb
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Skip tests whose expectations change based on scheme registration. Patch 1: [This patch] Patch 2: Revert https://codereview.chromium.org/1142213002/ Patch 3: https://codereview.chromium.org/1139053004/ BUG=489672 R=hiroshige@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195541

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/security/cannot-read-self-from-file.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/security/cannot-read-self-from-file-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Would you mind looking at this, hiroshige@? Thanks! -mike
5 years, 7 months ago (2015-05-19 14:37:15 UTC) #1
Mike West
Since it's a reasonable time zone for you, Ken, would you mind stamping this?
5 years, 7 months ago (2015-05-19 16:29:41 UTC) #3
kenrb
lgtm
5 years, 7 months ago (2015-05-19 17:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143593006/20001
5 years, 7 months ago (2015-05-19 19:02:34 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 19:05:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195541

Powered by Google App Engine
This is Rietveld 408576698