components/infobars/core/simple_alert_infobar_delegate.h - Issue 1142153002: Simplify infobar expiry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars/core/simple_alert_infobar_delegate.h

Issue 1142153002: Simplify infobar expiry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android compile Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/infobars/core/simple_alert_infobar_delegate.h

diff --git a/components/infobars/core/simple_alert_infobar_delegate.h b/components/infobars/core/simple_alert_infobar_delegate.h

index 64dc03a7cbf063f9dad5ba6b209d3e17a80e567e..671bc155849d91c4c319c46260fcca8cd90bdcc1 100644

--- a/components/infobars/core/simple_alert_infobar_delegate.h

+++ b/components/infobars/core/simple_alert_infobar_delegate.h

@@ -31,7 +31,7 @@ class SimpleAlertInfoBarDelegate : public ConfirmInfoBarDelegate {

// ConfirmInfoBarDelegate:

int GetIconID() const override;

- bool ShouldExpireInternal(const NavigationDetails& details) const override;

+ bool ShouldExpire(const NavigationDetails& details) const override;

base::string16 GetMessageText() const override;

int GetButtons() const override;