components/infobars/core/simple_alert_infobar_delegate.cc - Issue 1142153002: Simplify infobar expiry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars/core/simple_alert_infobar_delegate.cc

Issue 1142153002: Simplify infobar expiry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android compile Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/infobars/core/simple_alert_infobar_delegate.cc

diff --git a/components/infobars/core/simple_alert_infobar_delegate.cc b/components/infobars/core/simple_alert_infobar_delegate.cc

index fa0188e043d4a171512a8aa7967e45c044395384..56fbfce207a2119463d565c5a79d80e5388348ce 100644

--- a/components/infobars/core/simple_alert_infobar_delegate.cc

+++ b/components/infobars/core/simple_alert_infobar_delegate.cc

@@ -36,9 +36,9 @@ int SimpleAlertInfoBarDelegate::GetIconID() const {

return icon_id_;

}

-bool SimpleAlertInfoBarDelegate::ShouldExpireInternal(

+bool SimpleAlertInfoBarDelegate::ShouldExpire(

const NavigationDetails& details) const {

- return auto_expire_ && ConfirmInfoBarDelegate::ShouldExpireInternal(details);

+ return auto_expire_ && ConfirmInfoBarDelegate::ShouldExpire(details);

}

base::string16 SimpleAlertInfoBarDelegate::GetMessageText() const {