Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 11421187: Raise an exception if a unittest target is missing. (Closed)

Created:
8 years ago by frankf
Modified:
8 years ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Raise an exception if a unittest target is missing. BUG=163653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170592

Patch Set 1 #

Total comments: 2

Patch Set 2 : raise an Exception instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/android/run_tests.py View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
frankf
8 years ago (2012-11-30 22:45:05 UTC) #1
Isaac (away)
https://codereview.chromium.org/11421187/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): https://codereview.chromium.org/11421187/diff/1/build/android/run_tests.py#newcode120 build/android/run_tests.py:120: sys.exit(1) lets raise an exception instead of calling sys.exit. ...
8 years ago (2012-11-30 22:53:52 UTC) #2
frankf
PTAL https://codereview.chromium.org/11421187/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): https://codereview.chromium.org/11421187/diff/1/build/android/run_tests.py#newcode120 build/android/run_tests.py:120: sys.exit(1) Done. On 2012/11/30 22:53:52, Isaac wrote: > ...
8 years ago (2012-11-30 23:02:00 UTC) #3
Isaac (away)
lgtm
8 years ago (2012-11-30 23:03:16 UTC) #4
Isaac (away)
+jamesr FYI, this fixes the issue where the bot silently fails the to run tests, ...
8 years ago (2012-12-01 01:41:25 UTC) #5
jamesr
8 years ago (2012-12-01 01:42:03 UTC) #6
Message was sent while issue was closed.
On 2012/12/01 01:41:25, Isaac wrote:
> +jamesr FYI, this fixes the issue where the bot silently fails the to run
tests,
> which let your original CL pass CQ.

OK great.  Protecting yourself from my clumsiness is definitely a good idea :)

Powered by Google App Engine
This is Rietveld 408576698