Raise an exception if a unittest target is missing.

build/android/run_tests.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs all the native unit tests.
 
 1. Copy over test binary to /data/local on device.
 2. Resources: chrome/unit_tests requires resources (chrome.pak and en-US.pak)
@@ skipping 99 matching lines @@
     qualified_test_suites = [os.path.join(test_suite_dir,
                                           t + '_apk',
                                           t + '-debug.apk')
                              for t in all_test_suites]
   for t, q in zip(all_test_suites, qualified_test_suites):
     if not os.path.exists(q):
       logging.critical('Test suite %s not found in %s.\n'
                        'Supported test suites:\n %s\n'
                        'Ensure it has been built.\n',
                        t, q, _TEST_SUITES)
-      return []
+      sys.exit(1)

[Isaac (away), 2012/11/30 22:53:52]

lets raise an exception instead of calling sys.exit.  Don't like calling
sys.exit in subfunctions.

[frankf, 2012/11/30 23:02:00]

Done.

On 2012/11/30 22:53:52, Isaac wrote:

   return qualified_test_suites
 
 
 class TimeProfile(object):
   """Class for simple profiling of action, with logging of cost."""
 
   def __init__(self, description):
     self._description = description
     self.Start()
 
@@ skipping 334 matching lines @@
   # the batch (this happens because the exit status is a sum of all failures
   # from all suites, but the buildbot associates the exit status only with the
   # most recent step).
   if options.exit_code:
     return failed_tests_count
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))