Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1142113002: Remove SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 7 months ago
Reviewers:
enne (OOO), jam, sky, reed1
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS and convert existing clients to the public API. R=reed@google.com TBR=sky@chromium.org Committed: https://crrev.com/b4e5afcd821bf62c780bde10e60ffcbf96b13895 Cr-Commit-Position: refs/heads/master@{#330516}

Patch Set 1 #

Patch Set 2 : git cl format ui #

Patch Set 3 : fix cc unit tests #

Patch Set 4 : fix android/thumbnail_cache.cc #

Patch Set 5 : mac/accelerated_widget_mac.mm fix #

Patch Set 6 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M cc/output/software_renderer_unittest.cc View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M cc/resources/ui_resource_bitmap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/thumbnail/thumbnail_cache.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/skbitmap_operations.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
f(malita)
5 years, 7 months ago (2015-05-18 17:39:53 UTC) #1
reed1
lgtm
5 years, 7 months ago (2015-05-18 18:25:15 UTC) #2
f(malita)
+owners
5 years, 7 months ago (2015-05-18 19:21:02 UTC) #4
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-18 21:12:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142113002/80001
5 years, 7 months ago (2015-05-18 21:44:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64468)
5 years, 7 months ago (2015-05-18 21:53:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142113002/100001
5 years, 7 months ago (2015-05-18 23:40:50 UTC) #12
jam
lgtm
5 years, 7 months ago (2015-05-18 23:45:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64496)
5 years, 7 months ago (2015-05-18 23:48:20 UTC) #15
f(malita)
TBR-ing trivial ui/gfx/ipc/gfx_param_traits.cc change.
5 years, 7 months ago (2015-05-19 13:04:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142113002/100001
5 years, 7 months ago (2015-05-19 13:04:56 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-19 13:44:47 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 13:45:40 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b4e5afcd821bf62c780bde10e60ffcbf96b13895
Cr-Commit-Position: refs/heads/master@{#330516}

Powered by Google App Engine
This is Rietveld 408576698