content/shell/renderer/layout_test/blink_test_runner.cc - Issue 1142113002: Remove SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1142113002: Remove SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/layout_test/blink_test_runner.cc

diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc

index 06b6fee14e51009b6ce8e4b630e119f8a2e6c4e9..905eb5ff4116f096bb3c3ae8732aa553f25c4783 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.cc

+++ b/content/shell/renderer/layout_test/blink_test_runner.cc

@@ -757,8 +757,8 @@ void BlinkTestRunner::CaptureDump() {

}

void BlinkTestRunner::CaptureDumpPixels(const SkBitmap& snapshot) {

- DCHECK_NE(0, snapshot.info().fWidth);

- DCHECK_NE(0, snapshot.info().fHeight);

+ DCHECK_NE(0, snapshot.info().width());

+ DCHECK_NE(0, snapshot.info().height());

SkAutoLockPixels snapshot_lock(snapshot);

// The snapshot arrives from the GPU process via shared memory. Because MSan