Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Unified Diff: cc/test/pixel_test_utils.cc

Issue 11420079: Allow using a larger-than-necessary texture as cached render pass backing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: seems to work Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/pixel_test_utils.cc
diff --git a/cc/test/pixel_test_utils.cc b/cc/test/pixel_test_utils.cc
index ad455c0e37927b95f411699d722a2e8b7f0e9296..6e803485959f45e453c42bb95b223917cb4d2038 100644
--- a/cc/test/pixel_test_utils.cc
+++ b/cc/test/pixel_test_utils.cc
@@ -39,6 +39,7 @@ bool IsSameAsPNGFile(const SkBitmap& gen_bmp, FilePath ref_img_path) {
SkBitmap ref_bmp;
if (!ReadPNGFile(ref_img_path, &ref_bmp)) {
LOG(ERROR) << "Cannot read reference image: " << ref_img_path.value();
+ WritePNGFile(gen_bmp, ref_img_path);
enne (OOO) 2012/12/12 23:41:54 Is this intentional? (Also, the other change in th
jamesr 2012/12/13 01:15:06 no (although it's useful when debugging). removed
return false;
}
@@ -70,6 +71,7 @@ bool IsSameAsPNGFile(const SkBitmap& gen_bmp, FilePath ref_img_path) {
if (diff_pixels_count != 0) {
LOG(ERROR) << "Images differ by pixel count: " << diff_pixels_count;
+ //WritePNGFile(gen_bmp, FilePath("/tmp/actual.png"));
return false;
}

Powered by Google App Engine
This is Rietveld 408576698