Allow using a larger-than-necessary texture as cached render pass backing

cc/test/pixel_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/pixel_test_utils.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
@@ skipping 21 matching lines @@
   return file_util::ReadFileToString(file_path, &png_data) &&
          gfx::PNGCodec::Decode(reinterpret_cast<unsigned char*>(&png_data[0]),
                                png_data.length(),
                                bitmap);
 }
 
 bool IsSameAsPNGFile(const SkBitmap& gen_bmp, FilePath ref_img_path) {
   SkBitmap ref_bmp;
   if (!ReadPNGFile(ref_img_path, &ref_bmp)) {
     LOG(ERROR) << "Cannot read reference image: " << ref_img_path.value();
+    WritePNGFile(gen_bmp, ref_img_path);

[enne (OOO), 2012/12/12 23:41:54]

Is this intentional? (Also, the other change in this file, commented out?)

[jamesr, 2012/12/13 01:15:06]

no (although it's useful when debugging). removed

     return false;
   }
 
   if (ref_bmp.width() != gen_bmp.width() ||
       ref_bmp.height() != gen_bmp.height()) {
     LOG(ERROR)
         << "Dimensions do not match (Expected) vs (Actual):"
         << "(" << ref_bmp.width() << "x" << ref_bmp.height()
             << ") vs. "
         << "(" << gen_bmp.width() << "x" << gen_bmp.height() << ")";
@@ skipping 11 matching lines @@
     for (int y = 0; y < gen_bmp.height(); ++y) {
       if ((*gen_bmp.getAddr32(x, y) & kAlphaMask) !=
           (*ref_bmp.getAddr32(x, y) & kAlphaMask)) {
         ++diff_pixels_count;
       }
     }
   }
 
   if (diff_pixels_count != 0) {
     LOG(ERROR) << "Images differ by pixel count: " << diff_pixels_count;
+    //WritePNGFile(gen_bmp, FilePath("/tmp/actual.png"));
     return false;
   }
 
   return true;
 }
 
 }  // namespace test
 }  // namespace cc