Clean-up refactoring to eliminate GetLocalElementKind.

src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 391381d01d24e540cfe5edc8df63c7e83fec1176..6c3f017b57a345765b4b99e9e78512dcc53a0875 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5033,6 +5033,10 @@ bool JSReceiver::HasLocalProperty(String* name) {
 
 
 PropertyAttributes JSReceiver::GetPropertyAttribute(String* key) {
+  uint32_t index;
+  if (IsJSObject() && key->AsArrayIndex(&index)) {
+    return GetElementAttribute(index);
+  }

[Michael Starzinger, 2012/11/15 21:45:37]

I am not convinced that this is the right place to defer to the element-case if
the key is convertible to an index. I would rather have FooPropertyBar() only
deal with properties and FooElementBar() only deal with elements.

I understand that the callers throughout the codebase should have one entry
point and not care about that distinction. Maybe having
FooPropertyOrElementBar() in between would be a good idea. Now the name
obviously needs some improvement.

WDYT?

[rossberg, 2012/11/16 12:50:02]

I share your concern, but we already do this in various places in objects.cc, so
your suggestion would have to be part of a (much) larger (and likely
non-trivial) clean-up.

[Michael Starzinger, 2012/11/16 13:18:51]

Yes, I agree. This doesn't have to be part of this CL as long as we agree that
this particular situation is far from perfect.

   return GetPropertyAttributeWithReceiver(this, key);
 }