Clean-up refactoring to eliminate GetLocalElementKind.

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5015 matching lines @@
 
 bool JSReceiver::HasLocalProperty(String* name) {
   if (IsJSProxy()) {
     return JSProxy::cast(this)->HasPropertyWithHandler(name);
   }
   return GetLocalPropertyAttribute(name) != ABSENT;
 }
 
 
 PropertyAttributes JSReceiver::GetPropertyAttribute(String* key) {
+  uint32_t index;
+  if (IsJSObject() && key->AsArrayIndex(&index)) {
+    return GetElementAttribute(index);
+  }

[Michael Starzinger, 2012/11/15 21:45:37]

I am not convinced that this is the right place to defer to the element-case if
the key is convertible to an index. I would rather have FooPropertyBar() only
deal with properties and FooElementBar() only deal with elements.

I understand that the callers throughout the codebase should have one entry
point and not care about that distinction. Maybe having
FooPropertyOrElementBar() in between would be a good idea. Now the name
obviously needs some improvement.

WDYT?

[rossberg, 2012/11/16 12:50:02]

I share your concern, but we already do this in various places in objects.cc, so
your suggestion would have to be part of a (much) larger (and likely
non-trivial) clean-up.

[Michael Starzinger, 2012/11/16 13:18:51]

Yes, I agree. This doesn't have to be part of this CL as long as we agree that
this particular situation is far from perfect.

   return GetPropertyAttributeWithReceiver(this, key);
 }
 
 
 PropertyAttributes JSReceiver::GetElementAttribute(uint32_t index) {
   if (IsJSProxy()) {
     return JSProxy::cast(this)->GetElementAttributeWithHandler(this, index);
   }
   return JSObject::cast(this)->GetElementAttributeWithReceiver(
       this, index, true);
@@ skipping 495 matching lines @@
 #undef WRITE_UINT32_FIELD
 #undef READ_SHORT_FIELD
 #undef WRITE_SHORT_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_INL_H_