Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11419320: [Telemetry] Port page cycler to Telemetry. (Closed)

Created:
8 years ago by tonyg
Modified:
8 years ago
Reviewers:
bulach, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Port page cycler to Telemetry. BUG=163680 TEST=$ tools/perf/run_multipage_benchmarks --browser=system page_cycler tools/perf/page_sets/page_cycler/moz.json NOTRY=1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171246

Patch Set 1 #

Patch Set 2 : Adjust timeouts #

Total comments: 6

Patch Set 3 : Add test #

Patch Set 4 : Fix tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -4 lines) Patch
A tools/perf/page_sets/page_cycler/alexa_us.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/bloat.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/delete-transactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/insert-transactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/pseudo-random-transactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/select-readtransactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/select-readtransactions-read-results.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/select-transactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/database/update-transactions.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/dhtml.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/dom.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/intl1.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/intl2.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/morejs.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/morejsnp.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/moz.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/page_cycler/moz2.json View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/perf_tools/page_cycler.py View 1 1 chunk +38 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/inspector_page.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/inspector_page_unittest.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page_set_url_builder.py View 2 chunks +7 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page_set_url_builder_unittest.py View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
8 years ago (2012-12-04 23:07:04 UTC) #1
nduca
lgtm ish https://codereview.chromium.org/11419320/diff/2002/tools/perf/page_sets/page_cycler/moz.json File tools/perf/page_sets/page_cycler/moz.json (right): https://codereview.chromium.org/11419320/diff/2002/tools/perf/page_sets/page_cycler/moz.json#newcode5 tools/perf/page_sets/page_cycler/moz.json:5: "url": "file:///../../../../data/page_cycler/moz/start.html?iterations=10&auto=1", your indentation is mussed up ...
8 years ago (2012-12-05 00:30:19 UTC) #2
tonyg
https://codereview.chromium.org/11419320/diff/2002/tools/perf/page_sets/page_cycler/moz.json File tools/perf/page_sets/page_cycler/moz.json (right): https://codereview.chromium.org/11419320/diff/2002/tools/perf/page_sets/page_cycler/moz.json#newcode5 tools/perf/page_sets/page_cycler/moz.json:5: "url": "file:///../../../../data/page_cycler/moz/start.html?iterations=10&auto=1", On 2012/12/05 00:30:19, nduca wrote: > your ...
8 years ago (2012-12-05 01:14:01 UTC) #3
nduca
Url base dir seems to have a tab on it. When you look it in ...
8 years ago (2012-12-05 02:21:11 UTC) #4
tonyg
On 2012/12/05 02:21:11, nduca wrote: > Url base dir seems to have a tab on ...
8 years ago (2012-12-05 17:01:08 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-05 17:02:14 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698