Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: tools/telemetry/telemetry/page_set_url_builder_unittest.py

Issue 11419320: [Telemetry] Port page cycler to Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tabs Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page_set_url_builder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page_set_url_builder_unittest.py
diff --git a/tools/telemetry/telemetry/page_set_url_builder_unittest.py b/tools/telemetry/telemetry/page_set_url_builder_unittest.py
index 09ffbfeba4c4d069f1cbf183f3f1ea9e65646c52..7caddead68d427f38d0855bba96fb90da3056572 100644
--- a/tools/telemetry/telemetry/page_set_url_builder_unittest.py
+++ b/tools/telemetry/telemetry/page_set_url_builder_unittest.py
@@ -4,6 +4,7 @@
import unittest
import urlparse
+from telemetry import page
from telemetry import page_set_url_builder
class TestPageSetUrlBuilder(unittest.TestCase):
@@ -11,7 +12,7 @@ class TestPageSetUrlBuilder(unittest.TestCase):
url = 'file:///somedir/otherdir/file.html'
parsed_url = urlparse.urlparse(url)
base_dir = 'basedir'
- dirname, filename = page_set_url_builder.GetUrlBaseDirAndFile(base_dir,
+ dirname, filename = page_set_url_builder.GetUrlBaseDirAndFile({}, base_dir,
parsed_url)
self.assertEqual(dirname, 'basedir/somedir/otherdir')
self.assertEqual(filename, 'file.html')
@@ -20,7 +21,18 @@ class TestPageSetUrlBuilder(unittest.TestCase):
url = 'file:///../../otherdir/file.html'
parsed_url = urlparse.urlparse(url)
base_dir = 'basedir'
- dirname, filename = page_set_url_builder.GetUrlBaseDirAndFile(base_dir,
+ dirname, filename = page_set_url_builder.GetUrlBaseDirAndFile({}, base_dir,
parsed_url)
self.assertEqual(dirname, 'basedir/../../otherdir')
self.assertEqual(filename, 'file.html')
+
+ def testGetUrlBaseDirAndFileForUrlBaseDir(self):
+ url = 'file:///../../somedir/otherdir/file.html'
+ parsed_url = urlparse.urlparse(url)
+ base_dir = 'basedir'
+ apage = page.Page(url)
+ setattr(apage, 'url_base_dir', 'file:///../../somedir/')
+ dirname, filename = page_set_url_builder.GetUrlBaseDirAndFile(
+ apage, base_dir, parsed_url)
+ self.assertEqual(dirname, 'basedir/../../somedir/')
+ self.assertEqual(filename, 'otherdir/file.html')
« no previous file with comments | « tools/telemetry/telemetry/page_set_url_builder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698