[Download] Return DownloadInterruptReason from OnStartedCallback

[Download] Return DownloadInterruptReason from OnStartedCallback

DownloadUrlParameters::OnStartedCallback is invoked when the server
response is received for a newly started download. If there's an error,
this callback used to receive a net::Error indicating why.

This CL changes the return value to a DownloadInterruptReason so that
the callback can indicate error conditions that affect downloads that
aren't considered errors at the network layer. Also, it avoids having to
call DownloadManager::Start() when the response indicates that a
download is not possible.

Currently downloads that fail to start return a net::Error, but those
that fail after starting return a DownloadInterruptReason. With this
change, all downloads will return a DownloadInterruptReason regardless
of when the download is interrupted.

BUG=7648
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244657

[asanka, 2013-12-17 01:45:41]

Ben: Could you take a look? The pertinent changes are in /download/.

[benjhayden, 2013-12-17 18:12:52]

On 2013/12/17 01:45:41, asanka wrote:
> Ben: Could you take a look? The pertinent changes are in /download/.

Could you retry uploading?
error: old chunk mismatch

[benjhayden, 2013-12-17 18:22:47]

LGTM

Huh, the unified diffs still work even though the side-by-sides don't.

[asanka, 2013-12-17 18:26:05]

On 2013/12/17 18:22:47, benjhayden_chromium wrote:
> LGTM
> 
> Huh, the unified diffs still work even though the side-by-sides don't.

Thanks! I just uploaded a new patchset and this time the base files appear to
have made it.

[asanka, 2014-01-09 18:49:27]

Adding OWNERS. Apologies for the long list:

mnaganov:
  android_webview/

joi:
  content/public/

simonjam:
  content/browser/loader/

haven:
  chrome/browser/extensions/api/image_writer_private/

bauerb:
  chrome/browser/plugins/

dgrogan:
  content/browser/indexed_db/

asargent:
  chrome/browser/extensions/webstore_installer.*
  chrome/common/extensions/api/downloads.idl

sky:
  chrome/browser/history/

[Drew Haven, 2014-01-09 19:34:23]

lgtm

LGTM for chrome/browser/extensions/api/image_writer_private/

[James Simonsen, 2014-01-09 19:42:05]

lgtm

[Bernhard Bauer, 2014-01-09 19:59:49]

c/b/p LGTM.

[jsbell, 2014-01-09 21:21:11]

content/browser/indexed_db lgtm

[sky, 2014-01-09 21:44:47]

LGTM

[mnaganov (inactive), 2014-01-10 10:02:10]

android_webview/ LGTM

[Jói, 2014-01-10 13:03:42]

//content/public LGTM

[asargent_no_longer_on_chrome, 2014-01-10 23:20:58]

chrome/browser/extensions/webstore_installer.*
chrome/common/extensions/api/downloads.idl

lgtm

[asanka, 2014-01-13 16:46:39]

Thanks everyone!

dgrogan: ping?

[dgrogan, 2014-01-13 16:51:52]

jsbell lgtm'd for me

[asanka, 2014-01-13 17:31:01]

On 2014/01/13 16:51:52, dgrogan wrote:
> jsbell lgtm'd for me

Gotcha! Thanks

[commit-bot: I haz the power, 2014-01-13 23:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/114193009/70001

[commit-bot: I haz the power, 2014-01-14 06:15:06]

Change committed as 244657