chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 114193009: [Download] Return DownloadInterruptReason from OnStartedCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 114193009: [Download] Return DownloadInterruptReason from OnStartedCallback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 9dbf2e8b8c3899469059234eb9b4a5d0b1d579da..7d69b1eb7dbd3e49f7e56f40721883b43592eff1 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -366,7 +366,7 @@ class DownloadExtensionTest : public ExtensionApiTest {

" \"previous\": \"in_progress\","

" \"current\": \"interrupted\"}}]",

item->GetId(),

- content::InterruptReasonDebugString(

+ content::DownloadInterruptReasonToString(

expected_error).c_str()));

}

@@ -1679,13 +1679,13 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

<< kInvalidURLs[index];

}

- EXPECT_STREQ("net::ERR_ACCESS_DENIED", RunFunctionAndReturnError(

+ EXPECT_STREQ("NETWORK_INVALID_REQUEST", RunFunctionAndReturnError(

new DownloadsDownloadFunction(),

"[{\"url\": \"javascript:document.write(\\\"hello\\\");\"}]").c_str());

- EXPECT_STREQ("net::ERR_ACCESS_DENIED", RunFunctionAndReturnError(

+ EXPECT_STREQ("NETWORK_INVALID_REQUEST", RunFunctionAndReturnError(

new DownloadsDownloadFunction(),

"[{\"url\": \"javascript:return false;\"}]").c_str());

- EXPECT_STREQ("net::ERR_NOT_IMPLEMENTED", RunFunctionAndReturnError(

+ EXPECT_STREQ("NETWORK_FAILED", RunFunctionAndReturnError(

new DownloadsDownloadFunction(),

"[{\"url\": \"ftp://example.com/example.txt\"}]").c_str());

}