Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: vm/dart_api_impl.cc

Issue 11419261: Partial cleanup towards fixing Issue 6726 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/dart_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 15591)
+++ vm/dart_api_impl.cc (working copy)
@@ -1838,7 +1838,7 @@
if (instance.IsNull()) {
return Api::NewError("Object does not implement the List interface");
}
- String& name = String::Handle(isolate, String::New("length"));
+ String& name = String::Handle(isolate, Symbols::Length());
name = Field::GetterName(name);
const Function& function =
Function::Handle(isolate, Resolver::ResolveDynamic(instance, name, 1, 0));
@@ -1904,7 +1904,7 @@
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
- String& name = String::Handle(isolate, String::New("[]"));
+ String& name = String::Handle(isolate, Symbols::IndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 2, 0));
@@ -1956,7 +1956,7 @@
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
- String& name = String::Handle(isolate, String::New("[]="));
+ String& name = String::Handle(isolate, Symbols::AssignIndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 3, 0));
@@ -2038,7 +2038,7 @@
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
- String& name = String::Handle(isolate, String::New("[]"));
+ String& name = String::Handle(isolate, Symbols::IndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 2, 0));
@@ -2126,7 +2126,7 @@
const Instance& instance =
Instance::Handle(isolate, GetListInstance(isolate, obj));
if (!instance.IsNull()) {
- String& name = String::Handle(isolate, String::New("[]="));
+ String& name = String::Handle(isolate, Symbols::AssignIndexToken());
const Function& function =
Function::Handle(isolate,
Resolver::ResolveDynamic(instance, name, 3, 0));
« no previous file with comments | « no previous file | vm/dart_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698