Partial cleanup towards fixing Issue 6726

vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1820 matching lines @@
   }
   if (obj.IsGrowableObjectArray()) {
     GET_LIST_LENGTH(isolate, GrowableObjectArray, obj, len);
   }
   // Now check and handle a dart object that implements the List interface.
   const Instance& instance =
       Instance::Handle(isolate, GetListInstance(isolate, obj));
   if (instance.IsNull()) {
     return Api::NewError("Object does not implement the List interface");
   }
-  String& name = String::Handle(isolate, String::New("length"));
+  String& name = String::Handle(isolate, Symbols::Length());
   name = Field::GetterName(name);
   const Function& function =
       Function::Handle(isolate, Resolver::ResolveDynamic(instance, name, 1, 0));
   if (function.IsNull()) {
     return Api::NewError("List object does not have a 'length' field.");
   }
 
   GrowableArray<const Object*> args(0);
   const Array& kNoArgumentNames = Array::Handle(isolate);
   const Object& retval = Object::Handle(
@@ skipping 45 matching lines @@
     GET_LIST_ELEMENT(isolate, Array, obj, index);
   } else if (obj.IsGrowableObjectArray()) {
     GET_LIST_ELEMENT(isolate, GrowableObjectArray, obj, index);
   } else if (obj.IsError()) {
     return list;
   } else {
     // Check and handle a dart object that implements the List interface.
     const Instance& instance =
         Instance::Handle(isolate, GetListInstance(isolate, obj));
     if (!instance.IsNull()) {
-      String& name = String::Handle(isolate, String::New("[]"));
+      String& name = String::Handle(isolate, Symbols::IndexToken());
       const Function& function =
           Function::Handle(isolate,
                            Resolver::ResolveDynamic(instance, name, 2, 0));
       if (!function.IsNull()) {
         GrowableArray<const Object*> args(1);
         Integer& indexobj = Integer::Handle(isolate);
         indexobj = Integer::New(index);
         args.Add(&indexobj);
         const Array& kNoArgumentNames = Array::Handle(isolate);
         return Api::NewHandle(isolate, DartEntry::InvokeDynamic(
@@ skipping 31 matching lines @@
     SET_LIST_ELEMENT(isolate, Array, obj, index, value);
   } else if (obj.IsGrowableObjectArray()) {
     SET_LIST_ELEMENT(isolate, GrowableObjectArray, obj, index, value);
   } else if (obj.IsError()) {
     return list;
   } else {
     // Check and handle a dart object that implements the List interface.
     const Instance& instance =
         Instance::Handle(isolate, GetListInstance(isolate, obj));
     if (!instance.IsNull()) {
-      String& name = String::Handle(isolate, String::New("[]="));
+      String& name = String::Handle(isolate, Symbols::AssignIndexToken());
       const Function& function =
           Function::Handle(isolate,
                            Resolver::ResolveDynamic(instance, name, 3, 0));
       if (!function.IsNull()) {
         const Integer& index_obj =
             Integer::Handle(isolate, Integer::New(index));
         const Object& value_obj =
             Object::Handle(isolate, Api::UnwrapHandle(value));
         if (!value_obj.IsNull() && !value_obj.IsInstance()) {
           RETURN_TYPE_ERROR(isolate, value, Instance);
@@ skipping 61 matching lines @@
                               native_array,
                               offset,
                               length);
   } else if (obj.IsError()) {
     return list;
   } else {
     // Check and handle a dart object that implements the List interface.
     const Instance& instance =
         Instance::Handle(isolate, GetListInstance(isolate, obj));
     if (!instance.IsNull()) {
-      String& name = String::Handle(isolate, String::New("[]"));
+      String& name = String::Handle(isolate, Symbols::IndexToken());
       const Function& function =
           Function::Handle(isolate,
                            Resolver::ResolveDynamic(instance, name, 2, 0));
       if (!function.IsNull()) {
         Object& result = Object::Handle(isolate);
         Integer& intobj = Integer::Handle(isolate);
         for (int i = 0; i < length; i++) {
           intobj = Integer::New(offset + i);
           GrowableArray<const Object*> args(1);
           args.Add(&intobj);
@@ skipping 67 matching lines @@
                               native_array,
                               offset,
                               length);
   } else if (obj.IsError()) {
     return list;
   } else {
   // Check and handle a dart object that implements the List interface.
     const Instance& instance =
         Instance::Handle(isolate, GetListInstance(isolate, obj));
     if (!instance.IsNull()) {
-      String& name = String::Handle(isolate, String::New("[]="));
+      String& name = String::Handle(isolate, Symbols::AssignIndexToken());
       const Function& function =
           Function::Handle(isolate,
                            Resolver::ResolveDynamic(instance, name, 3, 0));
       if (!function.IsNull()) {
         Integer& indexobj = Integer::Handle(isolate);
         Integer& valueobj = Integer::Handle(isolate);
         for (int i = 0; i < length; i++) {
           indexobj = Integer::New(offset + i);
           valueobj = Integer::New(native_array[i]);
           GrowableArray<const Object*> args(2);
@@ skipping 2313 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success(isolate);
 }
 
 }  // namespace dart