|
Removes the |event| parameter from ActivationDelegate::ShouldActivate and makes the method const.
It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.
Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.
http://crbug.com/162100
R=sadrul@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170477
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+36 lines, -35 lines) |
Patch |
 |
M |
ash/test/test_activation_delegate.h
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_activation_delegate.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/activation_controller.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura.h
|
View
|
1
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura.cc
|
View
|
1
|
4 chunks |
+18 lines, -18 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/aura/client/activation_delegate.h
|
View
|
1
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/views/widget/desktop_aura/desktop_activation_client.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/widget/desktop_aura/desktop_native_widget_aura.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/widget/native_widget_aura.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/widget/native_widget_aura.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|