runtime/vm/dart_api_impl.cc - Issue 11419086: Use a signed 32-bit integer for representing code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: add missing files Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 88d0389e57560cb003aac5c0a69429c8cb73481e..76da06d1811601ff0a5188b95b747165303af20a 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1571,7 +1571,7 @@ DART_EXPORT Dart_Handle Dart_NewStringFromUTF16(const uint16_t* utf16_array,

}

-DART_EXPORT Dart_Handle Dart_NewStringFromUTF32(const uint32_t* utf32_array,

+DART_EXPORT Dart_Handle Dart_NewStringFromUTF32(const int32_t* utf32_array,

intptr_t length) {

Isolate* isolate = Isolate::Current();

DARTSCOPE(isolate);

« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »