Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 11418296: FTP: misc fixes resulting from my testing. (Closed)

Created:
8 years ago by Paweł Hajdan Jr.
Modified:
8 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

FTP: misc fixes resulting from my testing. - "total ..." lines can have values bigger than 32-bit - some servers use "l" as a flag in permission listing - some servers prepend garbage to the month column - NetWare directory listings can have spaces in file names - one additional variant of VMS error message BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170996

Patch Set 1 #

Patch Set 2 : data files #

Total comments: 2

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -9 lines) Patch
A net/data/ftp/dir-listing-ls-30 View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-30.expected View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-netware-3 View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-netware-3.expected View 1 2 1 chunk +188 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls_unittest.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
8 years ago (2012-12-03 20:54:42 UTC) #1
mmenke
https://codereview.chromium.org/11418296/diff/3001/net/ftp/ftp_directory_listing_parser_ls.cc File net/ftp/ftp_directory_listing_parser_ls.cc (right): https://codereview.chromium.org/11418296/diff/3001/net/ftp/ftp_directory_listing_parser_ls.cc#newcode27 net/ftp/ftp_directory_listing_parser_ls.cc:27: // l - unknown A quick search got me ...
8 years ago (2012-12-03 21:59:04 UTC) #2
Paweł Hajdan Jr.
PTAL
8 years ago (2012-12-04 17:41:47 UTC) #3
mmenke
8 years ago (2012-12-04 17:43:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698