FTP: misc fixes resulting from my testing.

net/ftp/ftp_directory_listing_parser_ls_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser_unittest.h"
 
 #include "base/format_macros.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "net/ftp/ftp_directory_listing_parser_ls.h"
@@ skipping 106 matching lines @@
       FtpDirectoryListingEntry::DIRECTORY, "tmp", -1,
       1994, 7, 28, 2, 41 },
 
     // Completely different date format (YYYY-MM-DD).
     { "drwxrwxrwx 2 root root  4096 2012-02-07 00:31 notas_servico",
       FtpDirectoryListingEntry::DIRECTORY, "notas_servico", -1,
       2012, 2, 7, 0, 31 },
     { "-rwxrwxrwx 2 root root  4096 2012-02-07 00:31 notas_servico",
       FtpDirectoryListingEntry::FILE, "notas_servico", 4096,
       2012, 2, 7, 0, 31 },
+
+    // Weird permission bits.
+    { "drwx--l---   2 0        10           512 Dec 22  1994 swetzel",
+      FtpDirectoryListingEntry::DIRECTORY, "swetzel", -1,
+      1994, 12, 22, 0, 0 },
+    { "drwxr-sr-x   5 22623    10           512 Jan 17  1996 sat-files",
+      FtpDirectoryListingEntry::DIRECTORY, "sat-files", -1,
+      1996, 1, 17, 0, 0 },

[mmenke, 2012/12/03 21:59:05]

Does this differ in any significant way from the 5th test?

"drwxrwsr-x    4 501      501          4096 Feb 20  2007 pub"

+
+    // Garbage in date (but still parseable).
+    { "lrw-rw-rw-   1 user     group         542 "
+      "/t11/member/incomingFeb  8  2007 "
+      "Shortcut to incoming.lnk -> /t11/member/incoming",
+      FtpDirectoryListingEntry::SYMLINK, "Shortcut to incoming.lnk", -1,
+      2007, 2, 8, 0, 0 },
   };
   for (size_t i = 0; i < arraysize(good_cases); i++) {
     SCOPED_TRACE(base::StringPrintf("Test[%" PRIuS "]: %s", i,
                                     good_cases[i].input));
 
     std::vector<FtpDirectoryListingEntry> entries;
     EXPECT_TRUE(ParseFtpDirectoryListingLs(
         GetSingleLineTestCase(good_cases[i].input),
         GetMockCurrentTime(),
         &entries));
@@ skipping 54 matching lines @@
     std::vector<FtpDirectoryListingEntry> entries;
     EXPECT_FALSE(ParseFtpDirectoryListingLs(GetSingleLineTestCase(bad_cases[i]),
                                             GetMockCurrentTime(),
                                             &entries));
   }
 }
 
 }  // namespace
 
 }  // namespace net