Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: content/renderer/render_view_impl.h

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use new webKit enum instead of string comparissons Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index ce73969bdbb9091d2e00114428b8d4c90bfe31f4..1dd08f66ebafa645637e45f104baa2cc70dde3b5 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -103,6 +103,8 @@ class WebApplicationCacheHostClient;
class WebCompositorOutputSurface;
class WebDOMMessageEvent;
class WebDataSource;
+class WebDateTimeChooserCompletion;
+class WebDateTimeChooserParams;
class WebDragData;
class WebGeolocationClient;
class WebGestureEvent;
@@ -155,6 +157,7 @@ class NotificationProvider;
class RenderViewObserver;
class RenderViewTest;
class RendererAccessibility;
+class RendererDateTimePickerImpl;
class RendererPpapiHost;
class RendererWebColorChooserImpl;
class RenderWidgetFullscreenPepper;
@@ -494,6 +497,11 @@ class CONTENT_EXPORT RenderViewImpl
virtual void cancelScheduledContentIntents();
virtual WebKit::WebContentDetectionResult detectContentAround(
const WebKit::WebHitTestResult& touch_hit);
+
+ // Only used on android since all other platforms implement
+ // MULTIPLE FIELDS
Peter Beverloo 2012/12/05 11:57:03 nit: s/android/Android/. I'd clarify what MULTIPLE
Miguel Garcia 2012/12/05 16:23:16 Done.
+ virtual bool openDateTimeChooser(const WebKit::WebDateTimeChooserParams&,
+ WebKit::WebDateTimeChooserCompletion*);
#endif
// WebKit::WebFrameClient implementation -------------------------------------
@@ -1435,7 +1443,10 @@ class CONTENT_EXPORT RenderViewImpl
// The active find-in-page match ordinal during synchronous requests.
// Needed to be remembered across WebKit callbacks.
int synchronous_find_active_match_ordinal_;
-#endif
+
+ // A date/time picker object for input type=date and similar.
Peter Beverloo 2012/12/05 11:57:03 s/for input type=date and similar/for date and tim
Miguel Garcia 2012/12/05 16:23:16 Done.
+ scoped_ptr<RendererDateTimePickerImpl> date_time_picker_client_;
+ #endif
Peter Beverloo 2012/12/05 11:57:03 No indenting for the #endif.
Miguel Garcia 2012/12/05 16:23:16 Done.
// Misc ----------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698