Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields.

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 85 matching lines @@
 class WebMediaPlayerManagerAndroid;
 }
 #endif
 
 namespace WebKit {
 class WebApplicationCacheHost;
 class WebApplicationCacheHostClient;
 class WebCompositorOutputSurface;
 class WebDOMMessageEvent;
 class WebDataSource;
+class WebDateTimeChooserCompletion;
+class WebDateTimeChooserParams;
 class WebDragData;
 class WebGeolocationClient;
 class WebGestureEvent;
 class WebIconURL;
 class WebImage;
 class WebPeerConnection00Handler;
 class WebPeerConnection00HandlerClient;
 class WebMediaPlayer;
 class WebMediaPlayerClient;
 class WebMouseEvent;
@@ skipping 32 matching lines @@
 class JavaBridgeDispatcher;
 class LoadProgressTracker;
 class MediaStreamDispatcher;
 class MediaStreamImpl;
 class MouseLockDispatcher;
 class NavigationState;
 class NotificationProvider;
 class RenderViewObserver;
 class RenderViewTest;
 class RendererAccessibility;
+class RendererDateTimePickerImpl;
 class RendererPpapiHost;
 class RendererWebColorChooserImpl;
 class RenderWidgetFullscreenPepper;
 class SpeechRecognitionDispatcher;
 class WebIntentsHost;
 class WebPluginDelegateProxy;
 struct CustomContextMenuContext;
 struct FileChooserParams;
 struct RenderViewImplParams;
 
@@ skipping 319 matching lines @@
                                        const WebKit::WebString& title);
   virtual WebKit::WebPageVisibilityState visibilityState() const;
   virtual WebKit::WebUserMediaClient* userMediaClient();
   virtual void draggableRegionsChanged();
 
 #if defined(OS_ANDROID)
   virtual void scheduleContentIntent(const WebKit::WebURL& intent);
   virtual void cancelScheduledContentIntents();
   virtual WebKit::WebContentDetectionResult detectContentAround(
       const WebKit::WebHitTestResult& touch_hit);
+
+  // Only used on android since all other platforms implement
+  // MULTIPLE FIELDS

[Peter Beverloo, 2012/12/05 11:57:03]

nit: s/android/Android/. I'd clarify what MULTIPLE FIELDS means, maybe "Only
used on Android. All other platforms implement date and time input fields using
multiple fields."?

[Miguel Garcia, 2012/12/05 16:23:16]

Done.

+  virtual bool openDateTimeChooser(const WebKit::WebDateTimeChooserParams&,
+                                   WebKit::WebDateTimeChooserCompletion*);
 #endif
 
   // WebKit::WebFrameClient implementation -------------------------------------
 
   virtual WebKit::WebPlugin* createPlugin(
       WebKit::WebFrame* frame,
       const WebKit::WebPluginParams& params);
   virtual WebKit::WebSharedWorker* createSharedWorker(
       WebKit::WebFrame* frame, const WebKit::WebURL& url,
       const WebKit::WebString& name, unsigned long long documentId);
@@ skipping 921 matching lines @@
   // created in the renderer process.
   scoped_ptr<webkit_media::MediaPlayerBridgeManagerImpl> media_bridge_manager_;
 
   // Holds the message used to return find results to the browser during
   // synchronous find-in-page requests. Only non-null during these requests.
   scoped_ptr<IPC::Message> synchronous_find_reply_message_;
 
   // The active find-in-page match ordinal during synchronous requests.
   // Needed to be remembered across WebKit callbacks.
   int synchronous_find_active_match_ordinal_;
-#endif
+
+  // A date/time picker object for input type=date and similar.

[Peter Beverloo, 2012/12/05 11:57:03]

s/for input type=date and similar/for date and time related input elements/.

[Miguel Garcia, 2012/12/05 16:23:16]

Done.

+  scoped_ptr<RendererDateTimePickerImpl> date_time_picker_client_;
+  #endif

[Peter Beverloo, 2012/12/05 11:57:03]

No indenting for the #endif.

[Miguel Garcia, 2012/12/05 16:23:16]

Done.

 
   // Misc ----------------------------------------------------------------------
 
   // The current and pending file chooser completion objects. If the queue is
   // nonempty, the first item represents the currently running file chooser
   // callback, and the remaining elements are the other file chooser completion
   // still waiting to be run (in order).
   struct PendingFileChooser;
   std::deque< linked_ptr<PendingFileChooser> > file_chooser_completions_;
 
@@ skipping 101 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_