Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use new webKit enum instead of string comparissons Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/ime_adapter_android.cc
diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc
index 3cae5ec00d87c0eb10b9687cdb3cc3003c7affe4..d2459609eba772b97c82fa23a65ff0408985e201 100644
--- a/content/browser/renderer_host/ime_adapter_android.cc
+++ b/content/browser/renderer_host/ime_adapter_android.cc
@@ -63,6 +63,11 @@ bool RegisterImeAdapter(JNIEnv* env) {
WebKit::WebInputEvent::ControlKey,
WebKit::WebInputEvent::CapsLockOn,
WebKit::WebInputEvent::NumLockOn);
+ // TODO(miguelg) note that WebKit is removing the date time related
+ // elements from the enum since they are no longer part of the text input
+ // possibilities. As the entry point is now different we can actually
Peter Beverloo 2012/12/05 11:57:03 Phrasing this as "note that WebKit is removing the
Miguel Garcia 2012/12/05 16:23:16 Done.
+ // tell the IME adapter if it's a dialog type or not without having to
Peter Beverloo 2012/12/05 11:57:03 nit: s/or not//
Miguel Garcia 2012/12/05 16:23:16 Done.
+ // reply on the enum values for that.
Java_ImeAdapter_initializeTextInputTypes(
env,
ui::TEXT_INPUT_TYPE_NONE,

Powered by Google App Engine
This is Rietveld 408576698