Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 11418295: Use WebCore:DateTimeChooser for date/time form types instead of considering them text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use new webKit enum instead of string comparissons Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/ime_adapter_android.h" 5 #include "content/browser/renderer_host/ime_adapter_android.h"
6 6
7 #include <android/input.h> 7 #include <android/input.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 Java_ImeAdapter_initializeWebInputEvents(env, 57 Java_ImeAdapter_initializeWebInputEvents(env,
58 WebKit::WebInputEvent::RawKeyDown, 58 WebKit::WebInputEvent::RawKeyDown,
59 WebKit::WebInputEvent::KeyUp, 59 WebKit::WebInputEvent::KeyUp,
60 WebKit::WebInputEvent::Char, 60 WebKit::WebInputEvent::Char,
61 WebKit::WebInputEvent::ShiftKey, 61 WebKit::WebInputEvent::ShiftKey,
62 WebKit::WebInputEvent::AltKey, 62 WebKit::WebInputEvent::AltKey,
63 WebKit::WebInputEvent::ControlKey, 63 WebKit::WebInputEvent::ControlKey,
64 WebKit::WebInputEvent::CapsLockOn, 64 WebKit::WebInputEvent::CapsLockOn,
65 WebKit::WebInputEvent::NumLockOn); 65 WebKit::WebInputEvent::NumLockOn);
66 // TODO(miguelg) note that WebKit is removing the date time related
67 // elements from the enum since they are no longer part of the text input
68 // possibilities. As the entry point is now different we can actually
Peter Beverloo 2012/12/05 11:57:03 Phrasing this as "note that WebKit is removing the
Miguel Garcia 2012/12/05 16:23:16 Done.
69 // tell the IME adapter if it's a dialog type or not without having to
Peter Beverloo 2012/12/05 11:57:03 nit: s/or not//
Miguel Garcia 2012/12/05 16:23:16 Done.
70 // reply on the enum values for that.
66 Java_ImeAdapter_initializeTextInputTypes( 71 Java_ImeAdapter_initializeTextInputTypes(
67 env, 72 env,
68 ui::TEXT_INPUT_TYPE_NONE, 73 ui::TEXT_INPUT_TYPE_NONE,
69 ui::TEXT_INPUT_TYPE_TEXT, 74 ui::TEXT_INPUT_TYPE_TEXT,
70 ui::TEXT_INPUT_TYPE_TEXT_AREA, 75 ui::TEXT_INPUT_TYPE_TEXT_AREA,
71 ui::TEXT_INPUT_TYPE_PASSWORD, 76 ui::TEXT_INPUT_TYPE_PASSWORD,
72 ui::TEXT_INPUT_TYPE_SEARCH, 77 ui::TEXT_INPUT_TYPE_SEARCH,
73 ui::TEXT_INPUT_TYPE_URL, 78 ui::TEXT_INPUT_TYPE_URL,
74 ui::TEXT_INPUT_TYPE_EMAIL, 79 ui::TEXT_INPUT_TYPE_EMAIL,
75 ui::TEXT_INPUT_TYPE_TELEPHONE, 80 ui::TEXT_INPUT_TYPE_TELEPHONE,
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 void ImeAdapterAndroid::Paste(JNIEnv* env, jobject) { 270 void ImeAdapterAndroid::Paste(JNIEnv* env, jobject) {
266 RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From( 271 RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(
267 rwhva_->GetRenderWidgetHost()); 272 rwhva_->GetRenderWidgetHost());
268 if (!rwhi) 273 if (!rwhi)
269 return; 274 return;
270 275
271 rwhi->Send(new ViewMsg_Paste(rwhi->GetRoutingID())); 276 rwhi->Send(new ViewMsg_Paste(rwhi->GetRoutingID()));
272 } 277 }
273 278
274 } // namespace content 279 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698