Issue 11418262: Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver call…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418262: Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver call… (Closed)

Created:
8 years ago by jam

Modified:
8 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver calls for the same window. The issue is that the observer wasn't unregistering itself at destruction. If another one happened to be created at the same memory address, then this check would trigger. BUG=163506 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170584

Patch Set 1 #

Patch Set 2 : check RootWindow before using it #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/browser/web_contents/web_contents_view_aura.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages