content/browser/web_contents/web_contents_view_aura.cc - Issue 11418262: Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver call…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 11418262: Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver call… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: check RootWindow before using it Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_view_aura.cc

===================================================================

--- content/browser/web_contents/web_contents_view_aura.cc (revision 170228)

+++ content/browser/web_contents/web_contents_view_aura.cc (working copy)

@@ -264,6 +264,8 @@

virtual ~WindowObserver() {

view_->window_->RemoveObserver(this);

+ if (view_->window_->GetRootWindow())

+ view_->window_->GetRootWindow()->RemoveRootWindowObserver(this);

if (parent_)

parent_->RemoveObserver(this);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »