Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 11418261: Browser Plugin: Update DOM Node attributes when properties are updated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits. Merged with ToT. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index e47fe771e47b77ae448495f0dc5a472c352d10f6..4c2b687d762618f3ba13346bce6f57466d7ddeb6 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -6,6 +6,7 @@
#include "base/json/json_string_value_serializer.h"
#include "base/message_loop.h"
+#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "content/common/browser_plugin_messages.h"
@@ -66,8 +67,8 @@ const char kOldWidth[] = "oldWidth";
const char kPartition[] = "partition";
const char kPersistPrefix[] = "persist:";
const char kProcessId[] = "processId";
-const char kSrc[] = "src";
const char kReason[] = "reason";
+const char kSrc[] = "src";
const char kURL[] = "url";
// Error messages.
@@ -259,6 +260,15 @@ bool BrowserPlugin::DamageBufferMatches(
}
#endif
+void BrowserPlugin::UpdateDOMAttribute(
+ const std::string& attribute_name, const std::string& attribute_value) {
sadrul 2012/12/03 21:58:44 each param in own line
Fady Samuel 2012/12/04 00:06:01 Done.
+ if (container()) {
+ container()->element().setAttribute(
+ WebKit::WebString::fromUTF8(attribute_name),
+ WebKit::WebString::fromUTF8(attribute_value));
+ }
+}
+
void BrowserPlugin::SetMaxHeightAttribute(int max_height) {
if (max_height_ == max_height)
return;
@@ -613,7 +623,10 @@ void BrowserPlugin::LoadCommit(
// If the guest has just committed a new navigation then it is no longer
// crashed.
guest_crashed_ = false;
- src_ = params.url.spec();
+ if (params.is_top_level) {
+ src_ = params.url.spec();
+ UpdateDOMAttribute(kSrc, src_.c_str());
+ }
process_id_ = params.process_id;
current_nav_entry_index_ = params.current_entry_index;
nav_entry_count_ = params.entry_count;

Powered by Google App Engine
This is Rietveld 408576698