Browser Plugin: Update DOM Node attributes when properties are updated

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include "base/json/json_string_value_serializer.h"
 #include "base/message_loop.h"
+#include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "content/common/browser_plugin_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 #include "content/renderer/browser_plugin/browser_plugin_manager.h"
 #include "content/renderer/render_process_impl.h"
 #include "content/renderer/render_thread_impl.h"
@@ skipping 40 matching lines @@
 const char kIsTopLevel[] = "isTopLevel";
 const char kNewURL[] = "newUrl";
 const char kNewHeight[] = "newHeight";
 const char kNewWidth[] = "newWidth";
 const char kOldURL[] = "oldUrl";
 const char kOldHeight[] = "oldHeight";
 const char kOldWidth[] = "oldWidth";
 const char kPartition[] = "partition";
 const char kPersistPrefix[] = "persist:";
 const char kProcessId[] = "processId";
+const char kReason[] = "reason";
 const char kSrc[] = "src";
-const char kReason[] = "reason";
 const char kURL[] = "url";
 
 // Error messages.
 const char kErrorAlreadyNavigated[] =
     "The object has already navigated, so its partition cannot be changed.";
 const char kErrorInvalidPartition[] =
     "Invalid partition attribute.";
 
 static std::string TerminationStatusToString(base::TerminationStatus status) {
   switch (status) {
@@ skipping 171 matching lines @@
 #else
 bool BrowserPlugin::DamageBufferMatches(
     const TransportDIB* damage_buffer,
     const TransportDIB::Handle& other_damage_buffer_handle) {
   if (!damage_buffer)
     return false;
   return damage_buffer->handle() == other_damage_buffer_handle;
 }
 #endif
 
+void BrowserPlugin::UpdateDOMAttribute(
+    const std::string& attribute_name, const std::string& attribute_value) {

[sadrul, 2012/12/03 21:58:44]

each param in own line

[Fady Samuel, 2012/12/04 00:06:01]

Done.

+  if (container()) {
+    container()->element().setAttribute(
+        WebKit::WebString::fromUTF8(attribute_name),
+        WebKit::WebString::fromUTF8(attribute_value));
+  }
+}
+
 void BrowserPlugin::SetMaxHeightAttribute(int max_height) {
   if (max_height_ == max_height)
     return;
   max_height_ = max_height;
   if (!auto_size_)
     return;
   UpdateGuestAutoSizeState();
 }
 
 void BrowserPlugin::SetMaxWidthAttribute(int max_width) {
@@ skipping 334 matching lines @@
   props[kIsTopLevel] = base::Value::CreateBooleanValue(is_top_level);
 
   TriggerEvent(kEventLoadStart, &props);
 }
 
 void BrowserPlugin::LoadCommit(
     const BrowserPluginMsg_LoadCommit_Params& params) {
   // If the guest has just committed a new navigation then it is no longer
   // crashed.
   guest_crashed_ = false;
-  src_ = params.url.spec();
+  if (params.is_top_level) {
+    src_ = params.url.spec();
+    UpdateDOMAttribute(kSrc, src_.c_str());
+  }
   process_id_ = params.process_id;
   current_nav_entry_index_ = params.current_entry_index;
   nav_entry_count_ = params.entry_count;
 
   std::map<std::string, base::Value*> props;
   props[kURL] = base::Value::CreateStringValue(src_);
   props[kIsTopLevel] = base::Value::CreateBooleanValue(params.is_top_level);
   TriggerEvent(kEventLoadCommit, &props);
 }
 
@@ skipping 350 matching lines @@
                                                  void* notify_data) {
 }
 
 void BrowserPlugin::didFailLoadingFrameRequest(
     const WebKit::WebURL& url,
     void* notify_data,
     const WebKit::WebURLError& error) {
 }
 
 }  // namespace content