Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 11418229: alternate ntp: implement right-aligned search token (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-impl as tab-to-search-ui-like bubble Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
index a3bae03af9a1b88dd14f2d62e2ac0b174b5eb0c0..37608680d3c1ee56c263a731c30329cb7cde782e 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
@@ -23,11 +23,15 @@ class ImageView;
class Label;
}
-// View used to draw a bubble to the left of the address, containing an icon and
-// a label. We use this as a base for the classes that handle the EV bubble and
-// tab-to-search UI.
+// View used to draw a bubble to the:
+// - left of the address, containing an icon and a label. We use this
+// as a base for the classes that handle the EV bubble and tab-to-search UI.
+// - right of the omnibox (left of all icons on the right of the omnibox),
+// containing just the label. We use this for the search bubble when omnibox
+// replaces the URL with its query terms.
Peter Kasting 2012/12/05 21:13:20 Nit: Instead of being so detailed here about the u
kuan 2012/12/11 21:10:29 Done.
class IconLabelBubbleView : public views::View {
public:
+ // Set |contained_image| to -1 if there's no icon.
beaudoin 2012/12/04 15:20:09 I think in this case it would be OK/cleaner to hav
Peter Kasting 2012/12/05 21:13:20 Because the two constructors' implementations woul
IconLabelBubbleView(const int background_images[],
int contained_image,
SkColor color);

Powered by Google App Engine
This is Rietveld 408576698