alternate ntp: implement right-aligned search token

chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_
 
 #include <string>
 
 #include "base/string16.h"
 #include "ui/gfx/size.h"
 #include "ui/views/painter.h"
 #include "ui/views/view.h"
 
 namespace gfx {
 class Canvas;
 class Font;
 class ImageSkia;
 }
 
 namespace views {
 class ImageView;
 class Label;
 }
 
-// View used to draw a bubble to the left of the address, containing an icon and
-// a label.  We use this as a base for the classes that handle the EV bubble and
-// tab-to-search UI.
+// View used to draw a bubble to the:
+// - left of the address, containing an icon and a label.  We use this
+//   as a base for the classes that handle the EV bubble and tab-to-search UI.
+// - right of the omnibox (left of all icons on the right of the omnibox),
+//   containing just the label.  We use this for the search bubble when omnibox
+//   replaces the URL with its query terms.

[Peter Kasting, 2012/12/05 21:13:20]

Nit: Instead of being so detailed here about the uses of this class, I'd just
say something simple and leave users to document things in more detail:

"View used to draw a bubble containing an optional icon followed by a label. 
This is used for e.g. the EV bubble and the tab-to-search UI."

[kuan, 2012/12/11 21:10:29]

Done.

 class IconLabelBubbleView : public views::View {
  public:
+  // Set |contained_image| to -1 if there's no icon.

[beaudoin, 2012/12/04 15:20:09]

I think in this case it would be OK/cleaner to have an overloaded constructor
without contained_image. Up to you.

[Peter Kasting, 2012/12/05 21:13:20]

Because the two constructors' implementations would be so similar, I'd weakly
rather not.

   IconLabelBubbleView(const int background_images[],
                       int contained_image,
                       SkColor color);
   virtual ~IconLabelBubbleView();
 
   void SetFont(const gfx::Font& font);
   void SetLabel(const string16& label);
   void SetImage(const gfx::ImageSkia& image);

[beaudoin, 2012/12/04 15:20:09]

Should maybe add a ClearImage(); to go full-circle with this. Again, up to you.

[Peter Kasting, 2012/12/05 21:13:20]

I wouldn't do this if we don't need it; I'm not a fan of dead APIs.

   void set_is_extension_icon(bool is_extension_icon) {
     is_extension_icon_ = is_extension_icon;
   }
 
   // Sets the label's text background color to |color|. Needed for correct
   // sub-pixel text rendering.
   void SetLabelBackgroundColor(SkColor color);
 
   // views::View overrides:
   virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
@@ skipping 14 matching lines @@
   // The contents of the bubble.
   views::ImageView* image_;
   views::Label* label_;
 
   bool is_extension_icon_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(IconLabelBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ICON_LABEL_BUBBLE_VIEW_H_