Update net/proxy unit test initialization of URLRequestJobFactory object.

net/proxy/proxy_script_fetcher_impl_unittest.cc

Index: net/proxy/proxy_script_fetcher_impl_unittest.cc
diff --git a/net/proxy/proxy_script_fetcher_impl_unittest.cc b/net/proxy/proxy_script_fetcher_impl_unittest.cc
index 7a25c5516b8f4ef30d13f1db28ba22f6e5aa399c..3e7503c6a120d553a8bbadc0ee7e0bfb0132bd3e 100644
--- a/net/proxy/proxy_script_fetcher_impl_unittest.cc
+++ b/net/proxy/proxy_script_fetcher_impl_unittest.cc
@@ -90,10 +90,10 @@ class RequestContext : public URLRequestContext {
     storage_.set_http_transaction_factory(new HttpCache(
         network_session,
         HttpCache::DefaultBackend::InMemory(0)));
-    url_request_job_factory_.reset(new URLRequestJobFactoryImpl);
-    set_job_factory(url_request_job_factory_.get());
-    url_request_job_factory_->AddInterceptor(
-        new CheckNoRevocationFlagSetInterceptor);
+    scoped_ptr<URLRequestJobFactoryImpl> factory(new URLRequestJobFactoryImpl);
+    set_job_factory(factory.get());
+    factory->AddInterceptor(new CheckNoRevocationFlagSetInterceptor);

[erikwright (departed), 2012/11/28 02:07:10]

nit: move AddInterceptor and the .Pass() above the call to set_job_factory.

set_job_factory seems to be kind of linked to the assumption that we are holding
ownership of the factory, which is not true until the .Pass() call.

+    url_request_job_factory_ = factory.Pass();
   }
 
   virtual ~RequestContext() {