Update net/proxy unit test initialization of URLRequestJobFactory object.

net/proxy/proxy_script_fetcher_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_script_fetcher_impl.h"
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/compiler_specific.h"
@@ skipping 72 matching lines @@
     params.host_resolver = host_resolver();
     params.cert_verifier = cert_verifier();
     params.proxy_service = proxy_service();
     params.ssl_config_service = ssl_config_service();
     params.http_server_properties = http_server_properties();
     scoped_refptr<HttpNetworkSession> network_session(
         new HttpNetworkSession(params));
     storage_.set_http_transaction_factory(new HttpCache(
         network_session,
         HttpCache::DefaultBackend::InMemory(0)));
-    url_request_job_factory_.reset(new URLRequestJobFactoryImpl);
-    set_job_factory(url_request_job_factory_.get());
-    url_request_job_factory_->AddInterceptor(
-        new CheckNoRevocationFlagSetInterceptor);
+    scoped_ptr<URLRequestJobFactoryImpl> factory(new URLRequestJobFactoryImpl);
+    set_job_factory(factory.get());
+    factory->AddInterceptor(new CheckNoRevocationFlagSetInterceptor);

[erikwright (departed), 2012/11/28 02:07:10]

nit: move AddInterceptor and the .Pass() above the call to set_job_factory.

set_job_factory seems to be kind of linked to the assumption that we are holding
ownership of the factory, which is not true until the .Pass() call.

+    url_request_job_factory_ = factory.Pass();
   }
 
   virtual ~RequestContext() {
   }
 
  private:
   URLRequestContextStorage storage_;
   scoped_ptr<URLRequestJobFactory> url_request_job_factory_;
 };
 
@@ skipping 391 matching lines @@
   {
     GURL url(kEncodedUrlBroken);
     string16 text;
     TestCompletionCallback callback;
     int result = pac_fetcher.Fetch(url, &text, callback.callback());
     EXPECT_EQ(ERR_FAILED, result);
   }
 }
 
 }  // namespace net