Update net/proxy unit test initialization of URLRequestJobFactory object.

Update net/proxy unit test initialization of URLRequestJobFactory object.

The associated CR involves moving mutation interfaces of URLRequestJobFactory to URLRequestJobFactory.  As such, their initializations need to maintain their type as URLRequestJobFactoryImpl before those interfaces can be removed.

See CL https://codereview.chromium.org/11227017 for more information.

BUG=146602
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171083

[erikwright (departed), 2012-11-28 02:07:10]

LGTM with nit.

https://codereview.chromium.org/11418203/diff/1/net/proxy/proxy_script_fetche...
File net/proxy/proxy_script_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/11418203/diff/1/net/proxy/proxy_script_fetche...
net/proxy/proxy_script_fetcher_impl_unittest.cc:95: factory->AddInterceptor(new
CheckNoRevocationFlagSetInterceptor);
nit: move AddInterceptor and the .Pass() above the call to set_job_factory.

set_job_factory seems to be kind of linked to the assumption that we are holding
ownership of the factory, which is not true until the .Pass() call.

[tedv, 2012-12-04 19:07:38]

Fixed this nit and pinging back to make sure it's somewhere on the review heap.

[willchan no longer on Chromium, 2012-12-04 19:50:56]

It was not but now it is. I still haven't caught up on all my reviews yet :(


On Tue, Dec 4, 2012 at 11:07 AM, <tedv@chromium.org> wrote:

> Fixed this nit and pinging back to make sure it's somewhere on the review
> heap.
>
>
https://codereview.chromium.**org/11418203/<https://codereview.chromium.org/1...
>

[willchan no longer on Chromium, 2012-12-04 20:24:42]

lgtm

[commit-bot: I haz the power, 2012-12-04 20:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedv@chromium.org/11418203/6001

[commit-bot: I haz the power, 2012-12-04 23:50:13]

Change committed as 171083