Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 11418183: Fix a bad merge that lead to unused optimization: implement the dataEquals in HInterceptor in order… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 15407)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -2385,6 +2385,11 @@
int typeCode() => HInstruction.INTERCEPTOR_TYPECODE;
bool typeEquals(other) => other is HInterceptor;
+ // We treat the data in a [HInterceptor] to always be equal to
+ // another, even if the [interceptedClasses] set is different. That
+ // is because we know the first [getInterceptor] call will fetch an
+ // interceptor of the right kind.
ahe 2012/11/27 18:29:01 How do you know that?
floitsch 2012/11/27 18:51:38 Because the input is the same.
ahe 2012/11/27 19:03:36 I'm still not sure I understand. Don't worry, I'l
+ bool dataEquals(other) => true;
}
/** An [HLazyStatic] is a static that is initialized lazily at first read. */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698