Fix a bad merge that lead to unused optimization: implement the dataEquals in HInterceptor in order…

sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBailoutTarget(HBailoutTarget node);
   R visitBitAnd(HBitAnd node);
@@ skipping 2367 matching lines @@
   accept(HVisitor visitor) => visitor.visitInterceptor(this);
   HInstruction get receiver => inputs[0];
 
   void prepareGvn(HTypeMap types) {
     clearAllSideEffects();
     setUseGvn();
   }
 
   int typeCode() => HInstruction.INTERCEPTOR_TYPECODE;
   bool typeEquals(other) => other is HInterceptor;
+  // We treat the data in a [HInterceptor] to always be equal to
+  // another, even if the [interceptedClasses] set is different. That
+  // is because we know the first [getInterceptor] call will fetch an
+  // interceptor of the right kind.

[ahe, 2012/11/27 18:29:01]

How do you know that?

[floitsch, 2012/11/27 18:51:38]

Because the input is the same.

[ahe, 2012/11/27 19:03:36]

I'm still not sure I understand.  Don't worry, I'll ask Nicolas for more details
tomorrow :-)

+  bool dataEquals(other) => true;
 }
 
 /** An [HLazyStatic] is a static that is initialized lazily at first read. */
 class HLazyStatic extends HStatic {
   HLazyStatic(Element element) : super(element);
 
   void prepareGvn(HTypeMap types) {
     // TODO(4931): The first access has side-effects, but we afterwards we
     // should be able to GVN.
     setAllSideEffects();
@@ skipping 537 matching lines @@
   HBasicBlock get start => expression.start;
   HBasicBlock get end {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty);
     return statements.last.end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }