[telemetry] fixing unit tests.

[telemetry] fixing unit tests.

NOTRY=true
BUG=

[hartmanng, 2012-11-22 14:08:47]

marja, since the others are presumably off for Thanksgiving, could you take a
look? It's a fairly trivial fix.

The change to desktop_browser_backend.py fixes the tests you were describing,
but I noticed test_adb_one_device
(telemetry.android_browser_finder_unittest.AndroidBrowserFinderTest) also
failed. I don't think that has to do with my CL, but I fixed it in
android_browser_finder.py anyway.

I'm actually a bit confused by that one though, let me know if you know what's
going on there. The failure I was seeing is this:

======================================================================
ERROR: test_adb_one_device
(telemetry.android_browser_finder_unittest.AndroidBrowserFinderTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/usr/local/google/home/hartmanng/chromium/src/tools/telemetry/telemetry/android_browser_finder_unittest.py",
line 87, in test_adb_one_device
    browsers = android_browser_finder.FindAllAvailableBrowsers(options)
  File
"/usr/local/google/home/hartmanng/chromium/src/tools/telemetry/telemetry/android_browser_finder.py",
line 141, in FindAllAvailableBrowsers
    if len(possible_browsers) and not adb_commands.HasForwarder():
TypeError: HasForwarder() takes exactly 1 argument (0 given)

which is odd because adb_commands.HasForwarder has a default value specified for
its one parameter, so I'm not sure why that was failing before.

[bulach, 2012-11-22 14:19:09]

ouch, I have a similar fix pending review :)
https://codereview.chromium.org/11280142/

[bulach, 2012-11-22 14:20:52]

..and the CQ just landed desktop_browser_backend.py fix as well :)
https://codereview.chromium.org/11280114/

[hartmanng, 2012-11-22 14:26:47]

Closing this, looks like bulach is a few steps ahead of me :)

[bulach, 2012-11-22 14:27:37]

oh, the timezones.. :) thanks for the quick review there!

[marja, 2012-11-22 15:18:34]

Does bulach's fix fix all the tests; afaics not, and the
desktop_browser_backend.py change is still needed. I didn't really check though.

[bulach, 2012-11-22 15:21:26]

marja: I think this patch:
https://codereview.chromium.org/11280114/

fixed the desktop_browser_backend.py (works for me! :) but please double
check... it has landed not too long ago..

[hartmanng, 2012-11-22 15:23:03]

On 2012/11/22 15:18:34, marja wrote:
> Does bulach's fix fix all the tests; afaics not, and the
> desktop_browser_backend.py change is still needed. I didn't really check
though.

On ToT everything passes for me except test_adb_one_device
(telemetry.android_browser_finder_unittest.AndroidBrowserFinderTest).
https://codereview.chromium.org/11280114/ fixed most of the tests and landed
about an hour ago, and https://codereview.chromium.org/11280142/ should fix the
last one.

[marja, 2012-11-22 15:27:09]

Ah, okay, thanks for checking (and fixing)!