Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: tools/telemetry/telemetry/android_browser_finder.py

Issue 11418131: [telemetry] fixing unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/telemetry/telemetry/desktop_browser_backend.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 """Finds android browsers that can be controlled by telemetry.""" 4 """Finds android browsers that can be controlled by telemetry."""
5 5
6 import os 6 import os
7 import logging as real_logging 7 import logging as real_logging
8 import re 8 import re
9 import subprocess 9 import subprocess
10 10
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 b = PossibleAndroidBrowser('android-jb-system-chrome', 131 b = PossibleAndroidBrowser('android-jb-system-chrome',
132 options, adb, 132 options, adb,
133 CHROME_JB_SYSTEM_PACKAGE, False, 133 CHROME_JB_SYSTEM_PACKAGE, False,
134 CHROME_COMMAND_LINE, 134 CHROME_COMMAND_LINE,
135 CHROME_ACTIVITY, 135 CHROME_ACTIVITY,
136 CHROME_JB_SYSTEM_DEVTOOLS_REMOTE_PORT) 136 CHROME_JB_SYSTEM_DEVTOOLS_REMOTE_PORT)
137 possible_browsers.append(b) 137 possible_browsers.append(b)
138 138
139 # See if the "forwarder" is installed -- we need this to host content locally 139 # See if the "forwarder" is installed -- we need this to host content locally
140 # but make it accessible to the device. 140 # but make it accessible to the device.
141 if len(possible_browsers) and not adb_commands.HasForwarder(): 141 if len(possible_browsers) and not adb_commands.HasForwarder(None):
142 logging.warn('telemetry detected an android device. However,') 142 logging.warn('telemetry detected an android device. However,')
143 logging.warn('Chrome\'s port-forwarder app is not available.') 143 logging.warn('Chrome\'s port-forwarder app is not available.')
144 logging.warn('To build:') 144 logging.warn('To build:')
145 logging.warn(' make -j16 host_forwarder device_forwarder') 145 logging.warn(' make -j16 host_forwarder device_forwarder')
146 logging.warn('') 146 logging.warn('')
147 logging.warn('') 147 logging.warn('')
148 return [] 148 return []
149 return possible_browsers 149 return possible_browsers
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/telemetry/desktop_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698