Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1141813002: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (2/3). (Closed)

Created:
5 years, 7 months ago by xiang
Modified:
5 years, 5 months ago
Reviewers:
falken, Mike West, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (2/3). The message sent from Service Worker to its client will land at navigator.serviceWorker.onmessage. The event type will be a new ServiceWorkerMessageEvent which 'source' attribute could be ServiceWorker or MessagePort. This's the Chrome side CL to include ServiceWorker info when dispatching message to renderer. spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworkermessage-event-section BUG=498596 Committed: https://crrev.com/665a49c42f91bb4259dd570de6f959be21d65ca6 Cr-Commit-Position: refs/heads/master@{#336725}

Patch Set 1 #

Total comments: 2

Patch Set 2 : for #3 #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 2 3 chunks +3 lines, -7 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 2 2 chunks +9 lines, -11 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
xiang
PTAL, thanks.
5 years, 7 months ago (2015-05-15 06:01:02 UTC) #2
falken
https://codereview.chromium.org/1141813002/diff/1/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/1141813002/diff/1/content/child/service_worker/service_worker_dispatcher.cc#newcode640 content/child/service_worker/service_worker_dispatcher.cc:640: GetServiceWorker(params.service_worker_info, false), nit: false /* adopt_handle */
5 years, 7 months ago (2015-05-18 03:37:09 UTC) #3
xiang
Cl updated, PTAL, thanks. https://codereview.chromium.org/1141813002/diff/1/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/1141813002/diff/1/content/child/service_worker/service_worker_dispatcher.cc#newcode640 content/child/service_worker/service_worker_dispatcher.cc:640: GetServiceWorker(params.service_worker_info, false), On 2015/05/18 03:37:09, ...
5 years, 6 months ago (2015-06-15 02:37:34 UTC) #4
falken
LGTM
5 years, 6 months ago (2015-06-25 03:51:22 UTC) #5
xiang
mkwst@ would you please review the IPC change? Thanks.
5 years, 5 months ago (2015-06-29 02:37:11 UTC) #7
Mike West
Adding content::ServiceWorkerObjectInfo to the IPC, and wrapping it in a struct, LGTM.
5 years, 5 months ago (2015-06-29 07:46:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141813002/40001
5 years, 5 months ago (2015-06-30 02:17:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-06-30 03:53:10 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 03:54:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/665a49c42f91bb4259dd570de6f959be21d65ca6
Cr-Commit-Position: refs/heads/master@{#336725}

Powered by Google App Engine
This is Rietveld 408576698