PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.

PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.

E.g.,
need to be in this order, since the latter uses definitions from the former.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169290

[marja, 2012-11-22 09:16:37]

Hi maruel, the #include check seems to be too strict regarding <sys/..>
includes.

An alternative approach would've been to add some
#include <weird.h> // presubmit-bypass-include-order-check
but... it clutters the code.

Wdyt?

[M-A Ruel, 2012-11-22 14:36:51]

On 2012/11/22 09:16:37, marja wrote:
> An alternative approach would've been to add some
> #include <weird.h> // presubmit-bypass-include-order-check
> but... it clutters the code.

It's not worth doing something like that. It doesn't pass the trade-off test.

https://codereview.chromium.org/11418128/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11418128/diff/1/PRESUBMIT.py#newcode561
PRESUBMIT.py:561: # Exclude #include <sys/...> includes from the check; they
often need to
I'd exclude anything with the pattern \<.+\?/.+?\>

[marja, 2012-11-22 18:08:53]

Thanks for comments!

https://codereview.chromium.org/11418128/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/11418128/diff/1/PRESUBMIT.py#newcode561
PRESUBMIT.py:561: # Exclude #include <sys/...> includes from the check; they
often need to
On 2012/11/22 14:36:51, Marc-Antoine Ruel wrote:
> I'd exclude anything with the pattern \<.+\?/.+?\>

Done; though I used a simpler pattern:
\s*#include \<.*/.*'
(it should do the same thing; we're matching line by line, so even when matching
eagerly the regexps won't match too much...)

[M-A Ruel, 2012-11-22 18:11:08]

lgtm