PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 540 matching lines @@
   for (line_num, previous_line_num) in problem_linenums:
     if line_num in changed_linenums or previous_line_num in changed_linenums:
       warnings.append('    %s:%d' % (file_path, line_num))
   return warnings
 
 
 def _CheckIncludeOrderInFile(input_api, f, is_source, changed_linenums):
   """Checks the #include order for the given file f."""
 
   system_include_pattern = input_api.re.compile(r'\s*#include \<.*')
+  # Exclude #include <sys/...> includes from the check; they often need to

[M-A Ruel, 2012/11/22 14:36:51]

I'd exclude anything with the pattern \<.+\?/.+?\>

[marja, 2012/11/22 18:08:53]

Done; though I used a simpler pattern:
\s*#include \<.*/.*'
(it should do the same thing; we're matching line by line, so even when matching
eagerly the regexps won't match too much...)

+  # appear in a specific order.
+  sys_include_pattern = input_api.re.compile(r'\s*#include \<sys/.*')
   custom_include_pattern = input_api.re.compile(r'\s*#include "(?P<FILE>.*)"')
   if_pattern = input_api.re.compile(r'\s*#\s*(if|elif|else|endif).*')
 
   contents = f.NewContents()
   warnings = []
   line_num = 0
 
   # Handle the special first include for source files. If the header file is
   # some/path/file.h, the corresponding source file can be some/path/file.cc,
   # some/other/path/file.cc, some/path/file_platform.cc etc. It's also possible
@@ skipping 18 matching lines @@
         break
 
   # Split into scopes: Each region between #if and #endif is its own scope.
   scopes = []
   current_scope = []
   for line in contents[line_num:]:
     line_num += 1
     if if_pattern.match(line):
       scopes.append(current_scope)
       current_scope = []
-    elif (system_include_pattern.match(line) or
-          custom_include_pattern.match(line)):
+    elif ((system_include_pattern.match(line) or
+           custom_include_pattern.match(line)) and
+          not sys_include_pattern.match(line)):
       current_scope.append((line_num, line))
   scopes.append(current_scope)
 
   for scope in scopes:
     warnings.extend(_CheckIncludeOrderForScope(scope, input_api, f.LocalPath(),
                                                changed_linenums))
   return warnings
 
 
 def _CheckIncludeOrder(input_api, output_api):
@@ skipping 212 matching lines @@
 
   # Match things like path/aura/file.cc and path/file_aura.cc.
   # Same for ash and chromeos.
   if any(re.search('[/_](ash|aura)', f) for f in files):
     trybots += ['linux_chromeos_clang:compile', 'win_aura',
                 'linux_chromeos_asan']
   elif any(re.search('[/_]chromeos', f) for f in files):
     trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan']
 
   return trybots