Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: cc/render_pass_unittest.cc

Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/render_pass.h" 5 #include "cc/render_pass.h"
6 6
7 #include "cc/checkerboard_draw_quad.h" 7 #include "cc/checkerboard_draw_quad.h"
8 #include "cc/test/geometry_test_utils.h" 8 #include "cc/test/geometry_test_utils.h"
9 #include "cc/test/render_pass_test_common.h" 9 #include "cc/test/render_pass_test_common.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 30 matching lines...) Expand all
41 gfx::Rect outputRect(45, 22, 120, 13); 41 gfx::Rect outputRect(45, 22, 120, 13);
42 WebTransformationMatrix transformToRoot(1, 0.5, 0.5, -0.5, -1, 0); 42 WebTransformationMatrix transformToRoot(1, 0.5, 0.5, -0.5, -1, 0);
43 gfx::Rect damageRect(56, 123, 19, 43); 43 gfx::Rect damageRect(56, 123, 19, 43);
44 bool hasTransparentBackground = true; 44 bool hasTransparentBackground = true;
45 bool hasOcclusionFromOutsideTargetSurface = true; 45 bool hasOcclusionFromOutsideTargetSurface = true;
46 WebFilterOperations filters; 46 WebFilterOperations filters;
47 WebFilterOperations backgroundFilters; 47 WebFilterOperations backgroundFilters;
48 48
49 filters.append(WebFilterOperation::createGrayscaleFilter(0.2f)); 49 filters.append(WebFilterOperation::createGrayscaleFilter(0.2f));
50 backgroundFilters.append(WebFilterOperation::createInvertFilter(0.2f)); 50 backgroundFilters.append(WebFilterOperation::createInvertFilter(0.2f));
51 SkAutoTUnref<SkBlurImageFilter> filter(new SkBlurImageFilter(SK_Scalar1, SK_ Scalar1)); 51 SkRefPtr<SkImageFilter> filter(new SkBlurImageFilter(SK_Scalar1, SK_Scalar1) );
Stephen White 2012/11/21 17:23:00 Same here. I think this'll leak.
52 52
53 scoped_ptr<TestRenderPass> pass = TestRenderPass::Create(); 53 scoped_ptr<TestRenderPass> pass = TestRenderPass::Create();
54 pass->SetAll(id, 54 pass->SetAll(id,
55 outputRect, 55 outputRect,
56 damageRect, 56 damageRect,
57 transformToRoot, 57 transformToRoot,
58 hasTransparentBackground, 58 hasTransparentBackground,
59 hasOcclusionFromOutsideTargetSurface, 59 hasOcclusionFromOutsideTargetSurface,
60 filters, 60 filters,
61 filter, 61 filter,
(...skipping 20 matching lines...) Expand all
82 EXPECT_EQ(pass->filters, copy->filters); 82 EXPECT_EQ(pass->filters, copy->filters);
83 EXPECT_EQ(pass->filter, copy->filter); 83 EXPECT_EQ(pass->filter, copy->filter);
84 EXPECT_EQ(pass->background_filters, copy->background_filters); 84 EXPECT_EQ(pass->background_filters, copy->background_filters);
85 EXPECT_EQ(0u, copy->quad_list.size()); 85 EXPECT_EQ(0u, copy->quad_list.size());
86 86
87 EXPECT_EQ(sizeof(RenderPassSize), sizeof(RenderPass)); 87 EXPECT_EQ(sizeof(RenderPassSize), sizeof(RenderPass));
88 } 88 }
89 89
90 } // namespace 90 } // namespace
91 } // namespace cc 91 } // namespace cc
OLDNEW
« cc/damage_tracker_unittest.cc ('K') | « cc/render_pass.cc ('k') | cc/software_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698