Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: cc/render_pass.h

Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/render_pass.h
diff --git a/cc/render_pass.h b/cc/render_pass.h
index e14b5e6d97be36eca25ccd83c3cb427f61668fec..9941b260e4ad62e360b41cc5aebedb851bfe3258 100644
--- a/cc/render_pass.h
+++ b/cc/render_pass.h
@@ -13,13 +13,13 @@
#include "cc/scoped_ptr_vector.h"
#include "cc/shared_quad_state.h"
#include "third_party/skia/include/core/SkColor.h"
+#include "third_party/skia/include/core/SkImageFilter.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
#include "ui/gfx/rect_f.h"
#include <public/WebFilterOperations.h>
#include <public/WebTransformationMatrix.h>
#include <vector>
-class SkImageFilter;
-
namespace cc {
// A list of DrawQuad objects, sorted internally in front-to-back order.
@@ -75,7 +75,7 @@ class CC_EXPORT RenderPass {
bool has_transparent_background,
bool has_occlusion_from_outside_target_surface,
const WebKit::WebFilterOperations& filters,
- SkImageFilter* filter,
+ const SkRefPtr<SkImageFilter>& filter,
const WebKit::WebFilterOperations& background_filters);
// Uniquely identifies the render pass in the compositor's current frame.
@@ -100,7 +100,7 @@ class CC_EXPORT RenderPass {
// pass' texture.
WebKit::WebFilterOperations filters;
// Post-processing filter applied to the pixels in the render pass' texture.
- SkImageFilter* filter;
+ SkRefPtr<SkImageFilter> filter;
// Post-processing filters, applied to the pixels showing through the
// background of the render pass, from behind it.

Powered by Google App Engine
This is Rietveld 408576698