Chromium Code Reviews
Help | Chromium Project | Sign in
(15)

Issue 11418062: Re-adjust access failure log messages for %GetOwnProperty. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by rossberg
Modified:
2 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Re-adjust access failure log messages for %GetOwnProperty. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13006

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M src/runtime.cc View 1 6 chunks +24 lines, -8 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
rossberg
2 years, 7 months ago (2012-11-19 14:22:50 UTC) #1
Michael Starzinger
LGTM with two comments. https://codereview.chromium.org/11418062/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1005 src/runtime.cc:1005: enum access_check_result { Rename this ...
2 years, 7 months ago (2012-11-19 14:35:03 UTC) #2
rossberg
2 years, 7 months ago (2012-11-19 17:58:48 UTC) #3
https://codereview.chromium.org/11418062/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1005
src/runtime.cc:1005: enum access_check_result {
On 2012/11/19 14:35:03, Michael Starzinger wrote:
> Rename this to AccessCheckResult.

Done.

https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1091
src/runtime.cc:1091: // Due to some WebKit tests, we want to make sure that we
do not log an
On 2012/11/19 14:35:03, Michael Starzinger wrote:
> s/do not log an access failure/do not log more than one access failure/

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d