Issue 11418062: Re-adjust access failure log messages for %GetOwnProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418062: Re-adjust access failure log messages for %GetOwnProperty. (Closed)

Created:
8 years, 1 month ago by rossberg

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Re-adjust access failure log messages for %GetOwnProperty. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13006

Patch Set 2 : Addressed comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -8 lines)			Patch
	M	src/runtime.cc	View	1	6 chunks	+24 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with two comments. https://codereview.chromium.org/11418062/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1005 src/runtime.cc:1005: enum access_check_result { Rename this ...

8 years, 1 month ago (2012-11-19 14:35:03 UTC) #2

rossberg

8 years, 1 month ago (2012-11-19 17:58:48 UTC) #3

https://codereview.chromium.org/11418062/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1005
src/runtime.cc:1005: enum access_check_result {
On 2012/11/19 14:35:03, Michael Starzinger wrote:
> Rename this to AccessCheckResult.

Done.

https://codereview.chromium.org/11418062/diff/1/src/runtime.cc#newcode1091
src/runtime.cc:1091: // Due to some WebKit tests, we want to make sure that we
do not log an
On 2012/11/19 14:35:03, Michael Starzinger wrote:
> s/do not log an access failure/do not log more than one access failure/

Done.

Expand Messages | Collapse Messages

Issue 11418062: Re-adjust access failure log messages for %GetOwnProperty. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages