Issue 11418032: Forward transition objects to grey if they are referenced by a large object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418032: Forward transition objects to grey if they are referenced by a large object (Closed)

Created:
8 years, 1 month ago by Hannes Payer (out of office)

Modified:
8 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Forward transition objects to grey if they are referenced by a large object BUG= Committed: https://code.google.com/p/v8/source/detail?r=13004

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	src/incremental-marking-inl.h	View	1	1 chunk	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comment. For the record, this change was already thoroughly reviewed in another ...

8 years, 1 month ago (2012-11-18 22:07:02 UTC) #2

Hannes Payer (out of office)

8 years, 1 month ago (2012-11-19 10:56:19 UTC) #3

https://codereview.chromium.org/11418032/diff/1/src/incremental-marking-inl.h
File src/incremental-marking-inl.h (right):

https://codereview.chromium.org/11418032/diff/1/src/incremental-marking-inl.h...
src/incremental-marking-inl.h:45: if (is_black) {
On 2012/11/18 22:07:02, Michael Starzinger wrote:
> Move the "Marking::IsBlack(obj_bit)" into the if condition.

Done.

Expand Messages | Collapse Messages