Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 11410080: Forward transition objects to grey if they are referenced by a large object (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by payer
Modified:
2 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Forward transition objects to grey if they are referenced by a large object BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/incremental-marking-inl.h View 1 2 1 chunk +11 lines, -5 lines 4 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
payer
2 years, 5 months ago (2012-11-14 07:58:37 UTC) #1
Michael Starzinger
https://codereview.chromium.org/11410080/diff/1/src/incremental-marking-inl.h File src/incremental-marking-inl.h (right): https://codereview.chromium.org/11410080/diff/1/src/incremental-marking-inl.h#newcode55 src/incremental-marking-inl.h:55: return false; This will prevent the slot from being ...
2 years, 5 months ago (2012-11-14 08:42:24 UTC) #2
payer
https://codereview.chromium.org/11410080/diff/1/src/incremental-marking-inl.h File src/incremental-marking-inl.h (right): https://codereview.chromium.org/11410080/diff/1/src/incremental-marking-inl.h#newcode55 src/incremental-marking-inl.h:55: return false; On 2012/11/14 08:42:24, Michael Starzinger wrote: > ...
2 years, 5 months ago (2012-11-14 09:12:37 UTC) #3
Michael Starzinger
https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h File src/incremental-marking-inl.h (right): https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h#newcode44 src/incremental-marking-inl.h:44: // TODO(hpayer): make decision based on if object has ...
2 years, 5 months ago (2012-11-15 18:04:26 UTC) #4
payer
2 years, 5 months ago (2012-11-16 13:43:05 UTC) #5
https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h
File src/incremental-marking-inl.h (right):

https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-in...
src/incremental-marking-inl.h:44: // TODO(hpayer): make decision based on if
object has a progress bar
On 2012/11/15 18:04:26, Michael Starzinger wrote:
> As discussed offline, can we rebase that to the brand new progress bar and
check
> for the HAS_PROGRESS_BAR page flag here?

Done.

I will add the optimization in the next CL.

https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-in...
src/incremental-marking-inl.h:49: } else if (Marking::IsBlack(obj_bit)) {
On 2012/11/15 18:04:26, Michael Starzinger wrote:
> Can we rewrite the condition so that it does the Marking::IsBlack only once,
> unfortunately GCC isn't smart enough to optimize it away.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771